fix: upgrade swc and add back explicit resource management#301
Merged
dsherret merged 1 commit intodenoland:mainfrom Apr 15, 2025
Merged
fix: upgrade swc and add back explicit resource management#301dsherret merged 1 commit intodenoland:mainfrom
dsherret merged 1 commit intodenoland:mainfrom
Conversation
bartlomieju
reviewed
Apr 15, 2025
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
Why adding back explicit resource management?
Member
Author
Because the v8 implementation has a bug if the scope is captured (they fixed it, but hasn't landed in deno yet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export default from;should not surface syntax error whenexportDefaultFrom: trueenabled swc-project/swc#10372